Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexpose #57

Closed
wants to merge 8 commits into from
Closed

Nexpose #57

wants to merge 8 commits into from

Conversation

mboman
Copy link
Contributor

@mboman mboman commented Dec 14, 2011

Changes from previous pull request:

  • Corrected whitespace (produces smaller diff)
  • Unnecessary hash initialization removed
  • Removed ncusage function (until a later, separate commit)
  • msftidy thinks it is cool (except for long banner lines)

Not fixed:

  • Nexpose_YAML constant still there. I am not at the moment good enough Ruby developer to know how to fix this.

mboman
mboman reviewed Dec 14, 2011
View reviewed changes
plugins/nexpose.rb
@@ -10,6 +10,8 @@
require 'rapid7/nexpose'

module Msf
Nexpose_yaml = "#{Msf::Config.get_config_root}/nexpose.yaml" #location of the nexpose.yml containing saved nexpose creds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant variable, like the Nessus plugin...

@todb-r7 todb-r7 closed this in 1102d56 Dec 23, 2011
shuckins-r7 added a commit that referenced this pull request Jul 21, 2014
@shuckins-r7
Merge pull request #57 from rapid7/bug/MSP-10004/rubyzip
84aa0d4 
Trevor added a 0.4.1 tag right before this PR landed, making this unmergable. Pulled in staging/electro-release, specs passing.
@julianvilas julianvilas mentioned this pull request Jan 29, 2015
Closed
Meatballs1 added a commit that referenced this pull request Jan 30, 2015
@Meatballs1
Merge pull request #57 from dmaloney-r7/feature/metaballs1/enum_ad_users
6b0de8c 
Feature/metaballs1/enum ad users
@julianvilas julianvilas mentioned this pull request Jan 30, 2015
Merged
@julianvilas julianvilas mentioned this pull request Mar 9, 2015
Merged
@0x00string 0x00string mentioned this pull request May 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboman @todb-r7