Update python meterpreter to include hex error code when format message fails #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Jun 14, 2023
| @@ -2899,7 +2899,7 @@ def stdapi_railgun_api(request, response): | |||
| if last_error == ERROR_SUCCESS: | |||
| error_message = 'The operation completed successfully.' | |||
| else: | |||
| error_message = 'FormatMessage failed to retrieve the error.' | |||
| error_message = 'FormatMessage failed to retrieve the error for value ' + hex(last_error) + '.' | |||
There was a problem hiding this comment.
Making this change so that it's more clear when an exception is raised that relies on this value, what the underlying problem is
Before:
[-] [should start W32Time] Exception: RuntimeError : Could not open service. OpenServiceA error: FormatMessage failed to retrieve the error for value.
After:
[-] [should start W32Time] Exception: RuntimeError : Could not open service. OpenServiceA error: FormatMessage failed to retrieve the error for value 0x6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.