Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add road vehicle height restriction units #30

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 11, 2020

Added a new feature property to indicate the unit of length posted on vehicle height restrictions. This information will allow iD’s Maximum Height field order to default to the locally appropriate unit: openstreetmap/iD#3614.

According to CLDR, Canada, India, the United Kingdom, and the United States use feet and inches for human-scale height measurements, while only the United Kingdom and United States measure road distances in miles instead of meters. That would imply that the U.K. and U.S. alone would measure vehicle height restrictions in feet and inches. However, not all U.S. overseas dependencies measure height in feet and inches (Puerto Rico being a notable exception), and various British overseas territories are represented separately in this JSON file. I did my best to figure out the height units in each territory based on this Wikipedia article, but it’s entirely possible that I under- or overcorrected.

This PR also corrects the road speed unit in some regions: Akrotiri and Dhekelia apparently uses the same signs as the Republic of Cyprus, which expresses speed limits in kilometers per hour. Some additional British overseas territories (Anguilla, South Georgia and South Sandwich Islands, and Montserrat) use imperial units, according to this table.

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 11, 2020

I’m open to calling this property something more generic. It’s pretty likely that vehicle lengths and distances between vehicles are expressed in the same unit as vehicle heights in every jurisdiction. On the other hand, iD may eventually need a separate property for human height measurements, which as stated above are expressed in feet and inches in Canada, India, and possibly elsewhere.

@quincylvania quincylvania merged commit f6db18c into rapideditor:master Oct 16, 2020
@quincylvania
Copy link
Contributor

@1ec5 Thanks! This is a great addition 👍

I’m open to calling this property something more generic.

I think it's fine as-is, we don't need to guarantee that these units will also be valid for other values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants