Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fire_hydrant_underground.svg #91

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

qugebert
Copy link
Contributor

I combined the existing icons from gas_manhole.svg and hydrant.svg and made it oval.

@bhousel
Copy link
Collaborator

bhousel commented Mar 11, 2024

Thanks!
Is this related to some other issue somewhere?
Also, why did you make it oval?

@qugebert
Copy link
Contributor Author

There has been the suggestion to make a seperate preset for underfloor hydrants to avoid confusion (pillar icon might be confusing for underfloor hydrants), somewhere here: streetcomplete/StreetComplete#5373 (comment)

It is oval, because all underfloor hydrant manholes i've ever seen are oval.
See for example https://wiki.openstreetmap.org/wiki/File:Berlin_hydrant_20050211_p1000517.jpg
and the actual pillar is mounted by firefighters if needed:
https://wiki.openstreetmap.org/wiki/File:Standrohr_unterflurhydrant.jpg
And in editors where the icons are quite small, the oval form might help to distinguish it as fire hydrant manhole.

But i didn't think that they might look different in other countries, sorry.

@qugebert
Copy link
Contributor Author

Ok, i tried how it would look in id-editor, the small icons are too small in all cases, but i think the round is a bit better.
grafik
grafik

@bhousel
Copy link
Collaborator

bhousel commented Mar 11, 2024

Thanks, yeah I agree that the round one looks a little better. At that small size it's really hard to see the details in either case, but I mostly think it would be weird for this icon to be a different shape from all the other ones.

@bhousel bhousel merged commit 018ae43 into rapideditor:main Mar 11, 2024
@qugebert qugebert deleted the fire_hydrant_underground branch March 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants