Add desktop/mobile navigation #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BobWez98
requested changes
Sep 16, 2024
royduin
requested changes
Sep 17, 2024
| @slots(['headerbutton']) | ||
|
|
||
| <x-rapidez::slideover.mobile | ||
| :title="(string) $title" |
There was a problem hiding this comment.
otherwise I get this error
| </a> | ||
| @endif | ||
| @if ($child['children']) | ||
| @php($childId = uniqid(Str::snake("{$child['title']}" ?? ''))) |
There was a problem hiding this comment.
This vs unique helpers provide by Laravel? Don't we have a unique ID already which we can use?
There was a problem hiding this comment.
this is using uniqid but it adds snake case to the title for whenever there are spaces in the title
I want to use the title here since it makes it more clear what id's and for's are linked to each other in your browser.
Could of course remove that part and only have uniqid but that would make the id a bit abstract and thus hard to debug if needed
BobWez98
requested changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.