Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override default max digits of 4 for nexmo gathers #140

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

nicpottier
Copy link
Member

Nexmo by default limits IVR digit gathers to 4 digits. This changes the default to be 20, their max. (you can still submit by pressing #)

@nicpottier nicpottier requested a review from rowanseymour June 17, 2019 17:41
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #140 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   43.24%   43.26%   +0.01%     
==========================================
  Files          68       68              
  Lines        6407     6409       +2     
==========================================
+ Hits         2771     2773       +2     
  Misses       3144     3144              
  Partials      492      492
Impacted Files Coverage Δ
ivr/nexmo/nexmo.go 26.75% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0027e4d...9f6da6e. Read the comment docs.

@nicpottier nicpottier merged commit 761cbb9 into master Jun 17, 2019
@nicpottier nicpottier deleted the nexmo-digit-count branch June 17, 2019 19:36
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
Update WENI-CHANGELOG.md for 1.4.7-courier-7.1.0
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants