Add PostgreSQL 11 tests #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked into this some and it looks like the problem is that pg11 can't read dumps from pg10 and our It does look like dumps from 11 work fine in 10 though. So we'll just have to create those there. I'll update this PR with that dump in a sec. |
|
@nicpottier I'm updating the dump in nyaruka#183 with PG10 |
|
Gonna have to be pg11 then to pass both. |
|
Bugger, I was being trigged by the binaries on my dev box. Reverting all this. We're going to test with 10 only on mailroom. |
|
Finally figured out the problem here. Dump needs to be created in 11 and that'll work across 10 and 11. So we are testing both now: Added assertion that the dump is being created in right version here: |
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Dec 5, 2024
Don't include templating variables if empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG11 wouldn't start without the
postgres-11-postgis-2.5-scriptspackage and this other hack: https://stackoverflow.com/questions/55161807/travis-ci-not-connecting-to-postgresql-11-2.It looks like the tests themselves are failing with PG11, though. Unfortunately, I'm not familiar enough with Go or the test suite to understand if it's actually a problem or just an issue with the tests :(