-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bothub classifier and add tests #196
Fix Bothub classifier and add tests #196
Conversation
Thanks, ya, that's kind of a shame, we are using a longer type for classifier types since that makes it easier for everyone. Why don't we change the type on the Bothub type to |
Hmmm, yeah make sense. I opened a PR for RapidPro here. I will change Here in this PR I'll remove the change for Can I proceed with these observations? |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 47.08% 47.08%
=======================================
Files 79 79
Lines 7038 7038
=======================================
Hits 3314 3314
Misses 3190 3190
Partials 534 534
Continue to review full report at Codecov.
|
Yep, that'd be perfect! |
Thanks guys! |
🖇 Fix twitter attachments
Email service construction should back down to parent org SMTP settings
Hi @nicpottier , we fix it the
ClassifierTypeBothub
forbh
and add BotHub type on the test list for run tests.Thanks a lot.
Regards