Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still do validation even when migrating to less than the current engine version #209

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

rowanseymour
Copy link
Contributor

Just realised we can still call ReadFlow so that we get structural validation.

  1. Do the JSON to JSON migration (e.g. 11.9 to 13.0.0)
  2. Call ReadFlow on the migrated JSON which internally will migrate to 13.1.0 but that we don't return the result of that so it doesn't matter

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #209 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   47.24%   47.25%   +0.01%     
==========================================
  Files          81       81              
  Lines        7023     7021       -2     
==========================================
  Hits         3318     3318              
+ Misses       3182     3181       -1     
+ Partials      523      522       -1
Impacted Files Coverage Δ
web/flow/flow.go 76.92% <100%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28877c...3757543. Read the comment docs.

@rowanseymour rowanseymour merged commit 93370f8 into master Dec 19, 2019
@rowanseymour rowanseymour deleted the migrate_tweak branch December 19, 2019 22:03
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Dec 16, 2024
Refactor queues to be struct instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants