Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest goflow #222

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Update to latest goflow #222

merged 1 commit into from
Jan 28, 2020

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@rowanseymour
Copy link
Contributor Author

@nicpottier I've found one more little thing to tweak in goflow - disallowing != for number and date fields and catching that at parse time too.. but just wanna check.. we really can't support that in ES?

@nicpottier
Copy link
Member

Can't I don't know for sure, but don't currently. Would have to do some research to figure all that out and whether there is a reason we don't support it now.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #222 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage    47.8%   47.69%   -0.12%     
==========================================
  Files          82       82              
  Lines        7204     7204              
==========================================
- Hits         3444     3436       -8     
- Misses       3233     3237       +4     
- Partials      527      531       +4
Impacted Files Coverage Δ
search/search.go 89.91% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a424947...dd7289f. Read the comment docs.

@rowanseymour rowanseymour merged commit f870f46 into master Jan 28, 2020
@rowanseymour
Copy link
Contributor Author

rowanseymour commented Jan 28, 2020

Merging this for now as it's a lot more correct than it was. Also note there's a drop in coverage because some evaluation errors are now technically impossible because they're caught at the parser stage.

@rowanseymour rowanseymour deleted the latest_goflow branch January 28, 2020 14:30
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
👐Send configured welcome message on conversation started for Viber
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Dec 16, 2024
Add endpoint for handling of incoming messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants