Asset cleanup #240
Asset cleanup #240
Conversation
| return nil, errors.Wrapf(err, "error marshalling flow definition") | ||
| func (a *OrgAssets) SetFlow(id FlowID, uuid assets.FlowUUID, name string, definition json.RawMessage) *Flow { | ||
| if !a.cloned { | ||
| panic("can only override flow definitions on cloned orgs") |
There was a problem hiding this comment.
I don't necessarily love this approach.. the better one would be to have a different type of org that satisfied the org interface but had this way of being modified, but that would have exceeded my budget for refactoring for the day and would require a lot of copy/paste.
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 48.94% 48.54% -0.41%
==========================================
Files 82 83 +1
Lines 7398 7457 +59
==========================================
- Hits 3621 3620 -1
- Misses 3205 3273 +68
+ Partials 572 564 -8
Continue to review full report at Codecov.
|
| @@ -68,11 +68,6 @@ func (f *Flow) FlowType() FlowType { return f.f.FlowType } | |||
| // Version returns the version this flow was authored in | |||
| func (f *Flow) Version() string { return f.f.Version } | |||
|
|
|||
| // SetDefinition sets our definition from the passed in definition | |||
There was a problem hiding this comment.
We want all our assets to be immutable. This is now handled by calling SetFlow on OrgAssets.
| // our flow contact | ||
| contact, err := c.FlowContact(org, sa) | ||
| contact, err := c.FlowContact(org) |
There was a problem hiding this comment.
A lot of signature changes like this as session assets are now cached on the org which makes the calls a lot simpler in many places. SessionAssets are thread safe and immutable ya @rowanseymour ?
There was a problem hiding this comment.
Yeah the only cleverness is trying to cache flow defs
There was a problem hiding this comment.
Is the caching thread safe?
There was a problem hiding this comment.
Update to latest goflow
Bit of refactoring around how our assets are loaded etc..
Callers can now request a cached org asset but can specify which pieces of the cache to refresh. This comes in handy for those endpoints that absolutely must have the most current stuff.
Also need some more thought around mucking with flows since new contact action endpoint needs to run "fake" flows in production. Decided to add a
Clonemethod that builds new assets but doesn't cache the result (and bases it off an existing env). Some runtime panics make sure you don't try to modify uncloned assets.