Update to goflow v0.72.0 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Feb 14, 2020
| @@ -19,8 +19,6 @@ func TestServer(t *testing.T) { | |||
| {URL: "/mr/flow/inspect", Method: "POST", Files: "inspect_invalid_legacy", Status: 200}, | |||
| {URL: "/mr/flow/inspect", Method: "POST", Files: "inspect_valid", Status: 200}, | |||
| {URL: "/mr/flow/inspect", Method: "POST", Files: "inspect_invalid", Status: 422}, | |||
| {URL: "/mr/flow/inspect", Method: "POST", Files: "inspect_valid_without_org", Status: 200}, | |||
| {URL: "/mr/flow/inspect", Method: "POST", Files: "inspect_invalid_without_org", Status: 200}, | |||
There was a problem hiding this comment.
we no longer call inspect without an org - used to be just to avoid an error
nicpottier
approved these changes
Feb 14, 2020
nicpottier
reviewed
Feb 14, 2020
| "key": "birthdate", | ||
| "name": "", | ||
| "type": "field" | ||
| } |
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 83 83
Lines 7457 7457
=======================================
Hits 3620 3620
Misses 3273 3273
Partials 564 564Continue to review full report at Codecov.
|
ericnewcomer
approved these changes
Feb 14, 2020
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
add clicksend channel
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Dec 16, 2024
Support either urn or phone on android endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.