Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mailroom test db, only prom group can access metrics #257

Merged
merged 1 commit into from
Apr 1, 2020
Merged

update mailroom test db, only prom group can access metrics #257

merged 1 commit into from
Apr 1, 2020

Conversation

nicpottier
Copy link
Member

No description provided.

@nicpottier nicpottier requested a review from rowanseymour March 31, 2020 22:33
rowanseymour
rowanseymour reviewed Mar 31, 2020
View reviewed changes
models/test_constants.go
@@ -19,7 +19,7 @@ import (
// we could start deriving these instead from the UUIDs.

var Org1 = OrgID(1)
var Org1UUID = uuids.UUID("7109adde-f322-4afa-bef5-328eb8a7f7eb")
var Org1UUID = uuids.UUID("bf0514a5-9407-44c9-b0f9-3f36f9c18414")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this and the flow changes are just extra UUIDs got generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #257 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files          86       86           
  Lines        7885     7885           
=======================================
  Hits         3891     3891           
  Misses       3382     3382           
  Partials      612      612
Impacted Files Coverage Δ
web/org/metrics.go 84.24% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c67b0...1947eea. Read the comment docs.

@nicpottier nicpottier merged commit 72022ad into master Apr 1, 2020
@nicpottier nicpottier deleted the update-test-db branch April 1, 2020 00:44
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Dec 16, 2024
@rowanseymour
Merge pull request rapidpro#257 from nyaruka/remove_scroll_api
0ab2b91 
Replace usage of deprecated elastic scroll API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanseymour rowanseymour rowanseymour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicpottier @rowanseymour