Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set org ID on new flow starts #265

Merged
merged 4 commits into from
Apr 13, 2020
Merged

Set org ID on new flow starts #265

merged 4 commits into from
Apr 13, 2020

Conversation

rowanseymour
Copy link
Contributor

@rowanseymour rowanseymour commented Apr 10, 2020

No description provided.

@rowanseymour rowanseymour requested a review from nicpottier April 10, 2020 16:45
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #265 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   49.41%   49.41%           
=======================================
  Files          86       86           
  Lines        7899     7899           
=======================================
  Hits         3903     3903           
  Misses       3383     3383           
  Partials      613      613           
Impacted Files Coverage Δ
models/starts.go 6.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c0c72...0988908. Read the comment docs.

@@ -329,7 +329,7 @@ func StartIVRFlow(
}

// get the flow for our start
start, err := models.GetFlowStartAttributes(ctx, db, org.OrgID(), startID)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed this arg isn't used..

@rowanseymour rowanseymour merged commit a5c8dee into master Apr 13, 2020
@rowanseymour rowanseymour deleted the flowstart_org_id branch April 13, 2020 21:10
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
…s-incoming

Fix error trying to update incoming message status
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants