Update to goflow v0.87.0 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jun 3, 2020
| for _, e := range es { | ||
| event := e.(*events.BroadcastCreatedEvent) | ||
|
|
||
| // we skip over any scene starts that involve groups if we are in a batch start | ||
| if len(scenes) > 1 && len(event.Groups) > 0 { |
There was a problem hiding this comment.
technically this wasn't correct because it could just the last batch of a large start and happen to have 1 contact
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 51.29% 51.32% +0.02%
==========================================
Files 98 98
Lines 8765 8760 -5
==========================================
Hits 4496 4496
+ Misses 3606 3603 -3
+ Partials 663 661 -2
Continue to review full report at Codecov.
|
nicpottier
approved these changes
Jun 3, 2020
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
Support using national number for EX channel if configured so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.