Update to goflow v0.89.0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jun 8, 2020
| (SELECT ARRAY_TO_JSON(ARRAY_AGG(ROW_TO_JSON(tr))) FROM ( | ||
| SELECT | ||
| tr.language as language, | ||
| '' as country, |
There was a problem hiding this comment.
still haven't added this to the DB yet
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 52.79% 53.40% +0.60%
==========================================
Files 101 101
Lines 8896 8904 +8
==========================================
+ Hits 4697 4755 +58
+ Misses 3514 3451 -63
- Partials 685 698 +13
Continue to review full report at Codecov.
|
rowanseymour
commented
Jun 8, 2020
| tc.HTTPMocks = clonedMocks | ||
| tc.actualResponse, err = ioutil.ReadAll(resp.Body) | ||
| assert.NoError(t, err, "%s: error reading body", tc.Label) | ||
|
|
||
| if !test.UpdateSnapshots { | ||
| assert.Equal(t, tc.Status, actual.Status, "%s: unexpected status", tc.Label) |
There was a problem hiding this comment.
shouldn't be asserting status if in -update mode
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
Allow to use config URL if set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.