🔎 Search by UUID #297
🔎 Search by UUID #297
Conversation
| @@ -172,7 +172,7 @@ func conditionToElasticQuery(env envs.Environment, resolver contactql.Resolver, | |||
|
|
|||
| // if we are looking for unset, inverse our query | |||
| if c.Comparator() == contactql.ComparatorEqual { | |||
| query = elastic.NewBoolQuery().MustNot(query) | |||
| query = not(query) | |||
There was a problem hiding this comment.
unrelated.. just added a util method below to reduce some repetition
| } else if key == contactql.AttributeID { | ||
| if c.Comparator() == contactql.ComparatorEqual { | ||
| return elastic.NewIdsQuery().Ids(value), nil | ||
| } else if c.Comparator() == contactql.ComparatorNotEqual { | ||
| return not(elastic.NewIdsQuery().Ids(value)), nil |
There was a problem hiding this comment.
I noticed the goflow side allows != for everything so thinking that's fine and allow it for id and uuid.. lets users exclude contacts from larger queries.. assuming this performs ok in elastic?
There was a problem hiding this comment.
Yes, don't think there should be any issues there.
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 53.54% 53.57% +0.02%
==========================================
Files 101 101
Lines 8904 8914 +10
==========================================
+ Hits 4768 4776 +8
- Misses 3438 3440 +2
Partials 698 698
Continue to review full report at Codecov.
|
| } else if key == contactql.AttributeID { | ||
| if c.Comparator() == contactql.ComparatorEqual { | ||
| return elastic.NewIdsQuery().Ids(value), nil | ||
| } else if c.Comparator() == contactql.ComparatorNotEqual { | ||
| return not(elastic.NewIdsQuery().Ids(value)), nil |
There was a problem hiding this comment.
Yes, don't think there should be any issues there.
Support sending documents for Telegram
No description provided.