Update to latest goflow v0.92.0 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 53.55% 52.74% -0.82%
==========================================
Files 101 99 -2
Lines 8910 8606 -304
==========================================
- Hits 4772 4539 -233
+ Misses 3440 3383 -57
+ Partials 698 684 -14
Continue to review full report at Codecov.
|
rowanseymour
commented
Jun 15, 2020
| Metadata *contactql.Inspection `json:"metadata,omitempty"` | ||
|
|
||
| // deprecated | ||
| Fields []string `json:"fields"` |
There was a problem hiding this comment.
i want to replace this with metadata above as it's always been a bit confusing to have something called fields that includes things like URN schemes - and we end up having to filter those out on the RP side
nicpottier
approved these changes
Jun 15, 2020
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
Enhancement/LINE sending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch stuff lives in goflow now