🚀 Remove redundant updates to modified_on #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 53.22% 53.20% -0.03%
==========================================
Files 99 99
Lines 8638 8625 -13
==========================================
- Hits 4598 4589 -9
+ Misses 3347 3345 -2
+ Partials 693 691 -2
Continue to review full report at Codecov.
|
norkans7
reviewed
Jun 26, 2020
| @@ -356,12 +356,6 @@ func handleModify(ctx context.Context, s *web.Server, r *http.Request) (interfac | |||
| return nil, http.StatusInternalServerError, errors.Wrapf(err, "error applying pre commit hooks") | |||
| } | |||
|
|
|||
| // apply modified_by | |||
| err = models.UpdateContactModifiedBy(ctx, tx, modifiedContactIDs, request.UserID) | |||
There was a problem hiding this comment.
I think you can remove modifiedContactIDs too above it is not used anymore
rowanseymour
commented
Jul 1, 2020
| if err != nil { | ||
| return errors.Wrapf(err, "error updating contacts modified_on") | ||
| } | ||
| } |
There was a problem hiding this comment.
done via the contactModifiedHook
rowanseymour
changed the title
nicpottier
approved these changes
Jul 1, 2020
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
Allow non-master releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.