💥 Fail flow starts which can't be started #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpottier
approved these changes
Jul 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 53.14% 53.22% +0.08%
==========================================
Files 99 99
Lines 8629 8638 +9
==========================================
+ Hits 4586 4598 +12
+ Misses 3352 3347 -5
- Partials 691 693 +2
Continue to review full report at Codecov.
|
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
Only log channel events when we have a channel matched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started off looking at https://sentry.io/organizations/nyaruka/issues/1756193944/?project=1281372&referrer=alert_email and wondering if invalid search queries could stay out of Sentry, but then noticed that we don't mark starts as failed when the handler task errors... or at least I'm not seeing any code anywhere which marks starts as failed.