Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and simplify creation of channel logs in IVR handlers #349

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

rowanseymour
Copy link
Contributor

Keep trying and failing to come up with a generic pattern for logging all requests - problem is handler wrapper functions don't mix and different handlers need to resolve different things in order to create logs - e.g. ticketer, channel etc. But this is a start and simplifies the creating channel logs for IVR handlers.

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #349 into master will decrease coverage by 0.04%.
The diff coverage is 39.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   54.76%   54.71%   -0.05%     
==========================================
  Files         106      106              
  Lines        8926     8872      -54     
==========================================
- Hits         4888     4854      -34     
+ Misses       3334     3323      -11     
+ Partials      704      695       -9     
Impacted Files Coverage Δ
web/ivr/ivr.go 45.83% <33.33%> (-4.97%) ⬇️
models/channel_logs.go 54.71% <100.00%> (+5.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61efa0...2380ab1. Read the comment docs.

@rowanseymour
Copy link
Contributor Author

This also fixes that currently we don't properly log responses to IVR requests to mailroom as we don't log headers - only the body

@rowanseymour rowanseymour changed the title Simplify creation of channel logs in IVR handlers Fix and simplify creation of channel logs in IVR handlers Sep 11, 2020
@rowanseymour rowanseymour merged commit e6ff7d2 into master Sep 11, 2020
@rowanseymour rowanseymour deleted the ivr_logs branch September 11, 2020 19:26
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
Add support for Zenvia WhatsApp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant