Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Make defining new task types easier and DRYer #354

Merged
merged 4 commits into from
Sep 11, 2020

Conversation

rowanseymour
Copy link
Contributor

Currently each task implements JSON deserialization of itself. Pushing that up a level, makes for less repetition, easier to test things. Tasks become structs with a Perform method.

So far I've only ported the two task types to the new way, as proof of concept.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #354 into master will increase coverage by 0.10%.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   54.66%   54.76%   +0.10%     
==========================================
  Files         106      108       +2     
  Lines        8883     8914      +31     
==========================================
+ Hits         4856     4882      +26     
+ Misses       3332     3330       -2     
- Partials      695      702       +7     
Impacted Files Coverage Δ
queue/queue.go 76.74% <ø> (ø)
tasks/base.go 46.15% <46.15%> (ø)
tasks/groups/populate_dynamic_group.go 72.00% <50.00%> (ø)
tasks/interrupts/interrupt_sessions.go 75.67% <92.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79195c...410f37f. Read the comment docs.

@rowanseymour rowanseymour merged commit 0135c4d into master Sep 11, 2020
@rowanseymour rowanseymour deleted the easier_tasks branch September 11, 2020 19:51
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
Update BL to remove UDH parameter and use HTTPS URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants