Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more tasks to new pattern #355

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #355 into master will increase coverage by 0.03%.
The diff coverage is 46.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   54.76%   54.80%   +0.03%     
==========================================
  Files         108      109       +1     
  Lines        8914     8905       -9     
==========================================
- Hits         4882     4880       -2     
+ Misses       3330     3324       -6     
+ Partials      702      701       -1     
Impacted Files Coverage Δ
queue/queue.go 76.74% <ø> (ø)
tasks/base.go 40.00% <0.00%> (-6.16%) ⬇️
tasks/groups/populate_dynamic_group.go 64.00% <25.00%> (-8.00%) ⬇️
tasks/interrupts/interrupt_sessions.go 70.27% <33.33%> (-5.41%) ⬇️
tasks/campaigns/fire_campaign_event.go 42.85% <42.85%> (ø)
tasks/campaigns/schedule_campaign_event.go 56.25% <56.25%> (ø)
tasks/campaigns/cron.go 68.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a6f44...dbea39e. Read the comment docs.

@rowanseymour rowanseymour merged commit 50270ff into master Sep 14, 2020
@rowanseymour rowanseymour deleted the more_tasks_cleanup branch September 14, 2020 15:48
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
Do not verify the SSL certificate for Bongo Live
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant