🔬 Add contact/resolve endpoint to assist with channel events still handled in RP #364
Conversation
| shouldErr func(funcName string, call int) error | ||
| real *sqlx.DB | ||
| callCounts map[string]int | ||
| callCountsMutex *sync.Mutex |
There was a problem hiding this comment.
unrelated - just noticed this class can panic if we end up with two threads writing to callCounts at exactly the same time
| @@ -128,12 +130,6 @@ func handleModify(ctx context.Context, s *web.Server, r *http.Request) (interfac | |||
| return nil, http.StatusInternalServerError, errors.Wrapf(err, "unable to load org assets") | |||
| } | |||
|
|
|||
| // clone it as we will modify flows | |||
There was a problem hiding this comment.
unrelated - this appears to be a turd from copy and pasting from the simulator endpoint
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 54.13% 54.20% +0.07%
==========================================
Files 112 112
Lines 8025 8042 +17
==========================================
+ Hits 4344 4359 +15
- Misses 2955 2956 +1
- Partials 726 727 +1
Continue to review full report at Codecov.
|
|
@nicpottier to set affinity on the URN |
|
But is that always required? Say adding a RapidPro contact manually before a channel exists. Take it that's a different api path? |
|
Yeah this endpoint is specifically for a channel interaction - and to be clear it's only for the relayer code in RP that will move to mailroom |
✈️ Always set `sent_on` for W/S/D statuses if not already set
No description provided.