Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in GetOrCreateContactIDsFromURNs #366

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #366 into master will increase coverage by 0.13%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   54.20%   54.33%   +0.13%     
==========================================
  Files         112      112              
  Lines        8042     8042              
==========================================
+ Hits         4359     4370      +11     
+ Misses       2956     2945      -11     
  Partials      727      727              
Impacted Files Coverage Δ
models/contacts.go 60.43% <70.37%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896ba60...a59c8db. Read the comment docs.

@rowanseymour rowanseymour force-pushed the bulk_contact_get_or_create_fix branch from bad638a to 9adcc36 Compare October 5, 2020 18:20
@rowanseymour rowanseymour force-pushed the bulk_contact_get_or_create_fix branch from 9adcc36 to a59c8db Compare October 5, 2020 20:27
@rowanseymour rowanseymour merged commit 81cfacf into master Oct 5, 2020
@rowanseymour rowanseymour deleted the bulk_contact_get_or_create_fix branch October 5, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant