FCM client improvements take II #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jan 14, 2021
| clientInit.Do(func() { | ||
| if config.Mailroom.FCMKey == "" { | ||
| logrus.Error("fcm not configured, no syncing of android channels") | ||
| return |
There was a problem hiding this comment.
this moves into mailroom instance startup - but just the warning - so it's not the first thing to appear in the console
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 115 115
Lines 7956 7956
=======================================
Hits 4390 4390
+ Misses 2868 2866 -2
- Partials 698 700 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.