Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move s3 session config error to a warning for the time being since no… #455

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

nicpottier
Copy link
Member

…t strictly required yet

@nicpottier nicpottier requested a review from rowanseymour July 6, 2021 18:50
@@ -1,9 +1,9 @@
# mailroom
# mailroom
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode seems to have cleaned up the markdown automatically, just added the s3 session stuff here.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #455 (7cd93ef) into main (a4da43b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files         123      123           
  Lines        8566     8566           
=======================================
  Hits         4839     4839           
  Misses       2950     2950           
  Partials      777      777           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4da43b...7cd93ef. Read the comment docs.

@nicpottier nicpottier merged commit 81299d7 into main Jul 6, 2021
@nicpottier nicpottier deleted the session-s3-warn branch July 6, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants