Log error if marking event fire as fired fails #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jul 19, 2021
| rerr := marker.RemoveTask(rc, campaignsLock, fmt.Sprintf("%d", failed.FireID)) | ||
| if rerr != nil { | ||
| log.WithError(rerr).WithField("fire_id", failed.FireID).Error("error unmarking campaign fire") | ||
| } |
There was a problem hiding this comment.
nicpottier
approved these changes
Jul 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 56.59% 56.57% -0.02%
==========================================
Files 123 123
Lines 8586 8588 +2
==========================================
Hits 4859 4859
- Misses 2950 2952 +2
Partials 777 777
Continue to review full report at Codecov.
|
|
@nicpottier well this is on the code that unmarks as fired, any contacts who failed.. i.e. any contacts not returned by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.