Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛑 Support flow config ivr_retry values of -1 meaning no retry #462

Merged
merged 1 commit into from
Jul 21, 2021
Merged

🛑 Support flow config ivr_retry values of -1 meaning no retry #462

merged 1 commit into from
Jul 21, 2021

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@rowanseymour rowanseymour requested a review from nicpottier July 20, 2021 21:48
@rowanseymour rowanseymour mentioned this pull request Jul 20, 2021
Merged
@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #462 (75d3f0c) into main (013438c) will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   56.57%   56.60%   +0.02%     
==========================================
  Files         123      123              
  Lines        8588     8593       +5     
==========================================
+ Hits         4859     4864       +5     
  Misses       2952     2952              
  Partials      777      777
Impacted Files Coverage Δ
core/models/channel_connection.go 22.29% <0.00%> (ø)
core/models/flows.go 80.85% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013438c...75d3f0c. Read the comment docs.

norkans7
norkans7 reviewed Jul 21, 2021
View reviewed changes
core/models/flows_test.go
ctx, rt, db, _ := testsuite.Get()

db.MustExec(`UPDATE flows_flow SET metadata = '{"ivr_retry": 30}'::json WHERE id = $1`, testdata.IVRFlow.ID)
db.MustExec(`UPDATE flows_flow SET metadata = '{"ivr_retry": -1}'::json WHERE id = $1`, testdata.SurveyorFlow.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about a new IVR flow instead of surveyor flow?

@rowanseymour rowanseymour merged commit e8cff47 into main Jul 21, 2021
@rowanseymour rowanseymour deleted the no_ivr_retry branch July 21, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkans7 norkans7 norkans7 approved these changes

@nicpottier nicpottier Awaiting requested review from nicpottier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanseymour @norkans7