🧯 Update contact modified_on after populate dynamic group task
#464
Conversation
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 56.59% 56.65% +0.05%
==========================================
Files 123 123
Lines 8594 8600 +6
==========================================
+ Hits 4864 4872 +8
+ Misses 2953 2951 -2
Partials 777 777
Continue to review full report at Codecov.
|
| changed = append(changed, adds...) | ||
| changed = append(changed, removals...) | ||
|
|
||
| err = UpdateContactModifiedOn(ctx, db, changed) |
There was a problem hiding this comment.
Maybe this all belongs on AddContactsToGroups and DeleteContactsFromGroups instead?
There was a problem hiding this comment.
I don't think so as those methods don't even hit the contacts_contact table and the other places we use them are when we're processing events/handlers/hooks and we've optimized updating modified_on for each contact.
There was a problem hiding this comment.
Ok. Ya, just feels likely we are going to make this bug again elsewhere when we change contact group membership elsewhere by calling this method, but I suppose we can just try to be extra careful.
No description provided.