Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧛 Populate ticket_count when creating new contacts #467

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

rowanseymour
Copy link
Contributor

@rowanseymour rowanseymour commented Jul 27, 2021

Requires nyaruka/rapidpro#3461 by deployed first

Also fixes tests broken by recent db changes to msgs and broadcasts.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #467 (39eb79d) into main (9f4fa51) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files         123      123           
  Lines        8598     8598           
=======================================
  Hits         4900     4900           
  Misses       2921     2921           
  Partials      777      777           
Impacted Files Coverage Δ
core/models/msgs.go 51.09% <ø> (ø)
core/models/contacts.go 62.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4fa51...39eb79d. Read the comment docs.

@rowanseymour rowanseymour merged commit 9b0247d into main Jul 28, 2021
@rowanseymour rowanseymour deleted the ticket_counts_pt1 branch July 28, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant