Implement asynchronous AMD for Twilio IVR #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're telling twilio to send back the AMD results on the same
handle?action=startendpoint which just results in that being called twice and blowing up the second time.So now it calls the status endpoint instead. If we see something like
AnsweredBy=machine_startwe mark the connection as errored, so that next time we resume, we see that, and send back error and<Hangup>.Note that in https://github.com/nyaruka/mailroom/pull/474 I got the synchronous version of AMD working but it results in a ~3 second pause at the start of every call which isn't ideal.