🙉 Add force param to close tickets endpoint to let us ignore errors #492
+94
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Sep 7, 2021
| @@ -65,16 +65,15 @@ func RunWebTests(t *testing.T, truthFile string, substitutions map[string]string | |||
|
|
|||
| actualResponse []byte | |||
| } | |||
| tcs := make([]*TestCase, 0, 20) | |||
| tcs := make([]TestCase, 0, 20) | |||
There was a problem hiding this comment.
we need actual := tc to copy by value.. the status check was never working
…external ticket service when removing a ticketer
rowanseymour
force-pushed
the
force_close
branch
from
abe3c84 to
6bc8d2a
Compare
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 57.12% 57.14% +0.02%
==========================================
Files 125 125
Lines 8706 8704 -2
==========================================
+ Hits 4973 4974 +1
+ Misses 2948 2946 -2
+ Partials 785 784 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. on an external ticket service when removing a ticketer