Explicitly exclude msg fields from marshaling that courier doesn't use #520

rowanseymour · 2021-11-09T19:27:03Z

Poking around at courier queues I noticed the message json has fields like MsgType, ConnectionID and TopupID which don't belong there.

	{
		"direction":"O",
		"modified_on":"2021-11-09T18:39:55.038607Z",
		"contact_urn_id":59726291,
		"session_id":970967356,
		"external_id":null,
		"MsgType":"F",
		"attachments":null,
                ...

rowanseymour · 2021-11-09T19:51:12Z

core/models/msgs_test.go

@@ -22,6 +25,11 @@ import (
 func TestOutgoingMsgs(t *testing.T) {
 	ctx, rt, db, _ := testsuite.Get()

+	defer func() {
+		testsuite.Reset(testsuite.ResetData)
+		db.MustExec(`UPDATE orgs_org SET is_suspended = FALSE`)


this test leaks changes to this in subsequent tests

codecov · 2021-11-09T19:55:48Z

Codecov Report

Merging #520 (819fcea) into main (84334fa) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   57.51%   57.53%   +0.01%     
==========================================
  Files         125      125              
  Lines        8790     8789       -1     
==========================================
+ Hits         5056     5057       +1     
+ Misses       2942     2940       -2     
  Partials      792      792

Impacted Files	Coverage Δ
core/models/msgs.go	`51.53% <ø> (+0.43%)`	⬆️
core/models/tickets.go	`71.03% <ø> (-0.10%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84334fa...819fcea. Read the comment docs.

Explicitly exclude msg fields from marshalling that courier doesn't use

819fcea

rowanseymour force-pushed the msg_json_fix branch from ea2037b to 819fcea Compare November 9, 2021 19:47

rowanseymour commented Nov 9, 2021

View reviewed changes

rowanseymour changed the base branch from main to 7.1 November 10, 2021 18:49

rowanseymour merged commit 89b58d7 into 7.1 Nov 10, 2021

rowanseymour deleted the msg_json_fix branch November 10, 2021 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explicitly exclude msg fields from marshaling that courier doesn't use #520

Explicitly exclude msg fields from marshaling that courier doesn't use #520

rowanseymour commented Nov 9, 2021

rowanseymour Nov 9, 2021

codecov bot commented Nov 9, 2021 •

edited

Loading

Explicitly exclude msg fields from marshaling that courier doesn't use #520

Explicitly exclude msg fields from marshaling that courier doesn't use #520

Conversation

rowanseymour commented Nov 9, 2021

rowanseymour Nov 9, 2021

Choose a reason for hiding this comment

codecov bot commented Nov 9, 2021 • edited Loading

Codecov Report

codecov bot commented Nov 9, 2021 •

edited

Loading