Allow expirations and timeouts to resume sessions for stopped and blocked contacts #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and archived contacts
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 61.77% 61.78% +0.01%
==========================================
Files 127 127
Lines 8952 8950 -2
==========================================
Hits 5530 5530
+ Misses 2555 2554 -1
+ Partials 867 866 -1
Continue to review full report at Codecov.
|
norkans7
reviewed
Mar 17, 2022
| assertdb.Query(t, db, `SELECT status FROM flows_flowsession WHERE id = $1;`, s5ID).Columns(map[string]interface{}{"status": "X"}) | ||
| assertdb.Query(t, db, `SELECT status FROM flows_flowrun WHERE id = $1;`, r6ID).Columns(map[string]interface{}{"status": "X"}) | ||
| assertdb.Query(t, db, `SELECT status FROM flows_flowrun WHERE id = $1;`, r7ID).Columns(map[string]interface{}{"status": "X"}) | ||
| // blocked contact's session and runs sshould be unchanged because it's been queued for resumption.. like any other contact |
norkans7
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/nyaruka/mailroom/pull/599. Completes https://github.com/rapidpro/rapidpro/issues/1629