Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new generic dbutil.BulkQuery #626

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Use new generic dbutil.BulkQuery #626

merged 1 commit into from
Apr 29, 2022

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #626 (25c145b) into main (3aa9745) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   61.93%   61.95%   +0.01%     
==========================================
  Files         130      130              
  Lines       12839    12800      -39     
==========================================
- Hits         7952     7930      -22     
+ Misses       4031     4015      -16     
+ Partials      856      855       -1     
Impacted Files Coverage Δ
core/models/labels.go 65.38% <0.00%> (+13.86%) ⬆️
core/models/resthooks.go 65.38% <0.00%> (+13.86%) ⬆️
core/models/groups.go 16.45% <100.00%> (-6.81%) ⬇️
core/models/http_logs.go 81.35% <100.00%> (+2.56%) ⬆️
core/models/notifications.go 100.00% <100.00%> (ø)
core/models/starts.go 57.62% <100.00%> (ø)
core/models/utils.go 80.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa9745...25c145b. Read the comment docs.

is := make([]interface{}, len(removals))
for i := range removals {
is[i] = removals[i]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤤

@rowanseymour rowanseymour merged commit 6ec3e87 into main Apr 29, 2022
@rowanseymour rowanseymour deleted the more_generics branch April 29, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants