Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ticket.opened_by and opened_in and set when opening tickets #641

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@@ -184,28 +188,28 @@ func (t *Ticket) ForwardIncoming(ctx context.Context, rt *runtime.Runtime, oa *O

const sqlSelectOpenTickets = `
SELECT
t.id AS id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this aliasing isn't needed

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #641 (6a8f32f) into main (ac359e0) will increase coverage by 0.02%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   61.96%   61.98%   +0.02%     
==========================================
  Files         132      132              
  Lines       12923    12933      +10     
==========================================
+ Hits         8008     8017       +9     
- Misses       4050     4051       +1     
  Partials      865      865              
Impacted Files Coverage Δ
core/models/events.go 73.37% <90.00%> (-0.82%) ⬇️
core/handlers/ticket_opened.go 84.48% <100.00%> (+2.85%) ⬆️
core/models/contacts.go 63.66% <100.00%> (ø)
core/models/imports.go 70.61% <100.00%> (ø)
core/models/tickets.go 68.30% <100.00%> (+0.13%) ⬆️
core/tasks/handler/worker.go 52.28% <100.00%> (ø)
web/contact/contact.go 67.74% <100.00%> (ø)

@rowanseymour rowanseymour force-pushed the ticket_opened_by_and_in branch from 077f4e6 to 6a8f32f Compare July 21, 2022 13:56
@rowanseymour rowanseymour merged commit 2fbc984 into main Jul 21, 2022
@rowanseymour rowanseymour deleted the ticket_opened_by_and_in branch July 21, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant