Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MsgOut.UnsendableReason instead of checking contact status #657

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

rowanseymour
Copy link
Contributor

Which might be different to what it was when the message was actually sent, e.g. a send message action and then a update status action

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #657 (29e82a4) into main (acd61cf) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   62.20%   62.17%   -0.04%     
==========================================
  Files         132      132              
  Lines       12894    12895       +1     
==========================================
- Hits         8021     8017       -4     
- Misses       4014     4017       +3     
- Partials      859      861       +2     
Impacted Files Coverage Δ
core/models/msgs.go 56.56% <54.54%> (-0.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 02a3f71 into main Sep 12, 2022
@rowanseymour rowanseymour deleted the unsendable branch September 12, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant