Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topups #668

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Remove topups #668

merged 4 commits into from
Oct 20, 2022

Conversation

rowanseymour
Copy link
Contributor

@rowanseymour rowanseymour commented Sep 30, 2022

Neded to first make some changes on RP side to hide topups counts and just show expiry date

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #668 (221fcbb) into main (738ca23) will increase coverage by 0.16%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   62.13%   62.30%   +0.16%     
==========================================
  Files         133      132       -1     
  Lines       12952    12981      +29     
==========================================
+ Hits         8048     8088      +40     
+ Misses       4036     4026      -10     
+ Partials      868      867       -1     
Impacted Files Coverage Δ
core/models/msgs.go 59.90% <0.00%> (+3.24%) ⬆️
core/models/orgs.go 56.91% <ø> (-0.35%) ⬇️
core/tasks/handler/worker.go 52.18% <87.50%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 86125a9 into main Oct 20, 2022
@rowanseymour rowanseymour deleted the remove_topups branch October 20, 2022 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants