Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send msg id to courier fetch-attachments endpoint #688

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

rowanseymour
Copy link
Contributor

and clean up flows.MsgID vs models.MsgID

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #688 (3a02cfe) into main (fd9b784) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   62.18%   62.17%   -0.01%     
==========================================
  Files         132      132              
  Lines       12867    12868       +1     
==========================================
  Hits         8001     8001              
- Misses       4007     4008       +1     
  Partials      859      859              
Impacted Files Coverage Δ
core/models/msgs.go 56.69% <0.00%> (ø)
core/msgio/courier.go 66.66% <0.00%> (-0.91%) ⬇️
core/tasks/handler/worker.go 51.90% <66.66%> (ø)
core/models/sessions.go 54.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 10aad1d into main Nov 14, 2022
@rowanseymour rowanseymour deleted the fetch_attachment_with_msg_id branch November 14, 2022 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant