Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry messages which fail to queue to courier #692

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

rowanseymour
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #692 (b0e50f5) into main (4bd7132) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   62.18%   62.19%           
=======================================
  Files         132      132           
  Lines       12871    12873    +2     
=======================================
+ Hits         8004     8006    +2     
  Misses       4008     4008           
  Partials      859      859           
Impacted Files Coverage Δ
core/models/msgs.go 56.82% <100.00%> (+0.12%) ⬆️
core/msgio/send.go 77.19% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ericnewcomer ericnewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do messages break out of this retry cycle?

@rowanseymour
Copy link
Contributor Author

They don't but I think that's ok because this isn't expected behavior like a channel not working - this is something broken in our deployment

@rowanseymour rowanseymour merged commit 92d6203 into main Dec 5, 2022
@rowanseymour rowanseymour deleted the retry_pending branch December 5, 2022 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants