Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port upstream fixes to skimage.transform estimate methods #207

Closed
wants to merge 2 commits into from
Closed

Port upstream fixes to skimage.transform estimate methods #207

wants to merge 2 commits into from

Conversation

chrisroat
Copy link

Porting the following changes:

  • ProjectiveTransform has a consistent failure state when estimate is ill-conditioned
  • SimilarityTransform.estimate returns False if ill-conditioned (currently always returns True)
  • PiecewiseSimilarityTransform.estimate returns False if any piece is illconditioned (currently always returns True)

Upstream refs:
scikit-image/scikit-image#6207
scikit-image/scikit-image#6211

Closes #199

@chrisroat chrisroat requested a review from a team as a code owner January 26, 2022 19:06
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@quasiben
Copy link
Member

add to allowlist

@quasiben quasiben added non-breaking Introduces a non-breaking change breaking Introduces a breaking change feature request New feature or request and removed breaking Introduces a breaking change labels Jan 26, 2022
@quasiben
Copy link
Member

Currently failing a small style check:

>>>> FAILED: flake8 style check; begin output
./src/cucim/skimage/transform/tests/test_geometric.py:612:1: E302 expected 2 blank lines, found 1

@quasiben
Copy link
Member

Also, Thanks @chrisroat !

@chrisroat
Copy link
Author

Currently failing a small style check:

>>>> FAILED: flake8 style check; begin output
./src/cucim/skimage/transform/tests/test_geometric.py:612:1: E302 expected 2 blank lines, found 1

Whoops! Fixed.

@jakirkham
Copy link
Member

@grlee77 could you please take a look? 🙂

@grlee77
Copy link
Contributor

grlee77 commented Jan 26, 2022

Sorry, I did not see this before opening #208 just now! The difference between the two is that gh-208 also changes PiecewiseAffineTransform to store the affine parameters on the GPU when the input arrays are on the GPU. The current behavior of always using the CPU is inconsistent with the other classes. See also comments in #208 (comment)

@grlee77
Copy link
Contributor

grlee77 commented Jan 26, 2022

I think we can close this one in favor of #208, but to credit @chrisroat, I will modify the commits with a "co-authored-by" statement there (Chris fixed the issues upstream in scikit-image).

@grlee77 grlee77 closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PiecewiseAffineTransform can trigger TypeError
5 participants