Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use make_device_uvector instead of cudaMemcpyAsync in inplace_bitmask_binop #17181

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Use make_device_uvector instead of cudaMemcpyAsync in inplace_bitmask_binop #17181

merged 2 commits into from
Oct 28, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 25, 2024 •
edited
Loading

Description

Changes cudf::detail::inplace_bitmask_binop() to use make_device_uvector() instead of cudaMemcpyAsync()
Found while working on #17149

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2024
@davidwendt davidwendt self-assigned this Oct 25, 2024
@davidwendt davidwendt changed the title Change inplace_bitmask_binop to use make_device_uvector instead of cudaMemcpyAsync Use make_device_uvector instead of cudaMemcpyAsync in inplace_bitmask_binop Oct 25, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 25, 2024
@davidwendt davidwendt marked this pull request as ready for review October 25, 2024 17:26
@davidwendt davidwendt requested a review from a team as a code owner October 25, 2024 17:26
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8c4d1f2 into rapidsai:branch-24.12 Oct 28, 2024
112 checks passed
@davidwendt davidwendt deleted the fix-ibb-memcpy branch October 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia