Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check num_children() == 0 in Column.from_column_view #17193

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Check num_children() == 0 in Column.from_column_view #17193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ead29e
check num_children() == 0 in Column.from_column_view
cwharris Oct 28, 2024
e75821d
Merge branch 'branch-24.12' of github.com:rapidsai/cudf into from-col…
cwharris Oct 28, 2024
3a8ba6f
Merge branch 'branch-24.12' of github.com:rapidsai/cudf into from-col…
cwharris Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions python/cudf/cudf/_lib/column.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,15 +688,18 @@ cdef class Column:
# special case for string column
is_string_column = (cv.type().id() == libcudf_types.type_id.STRING)
if is_string_column:
# get the size from offset child column (device to host copy)
offsets_column_index = 0
offset_child_column = cv.child(offsets_column_index)
if offset_child_column.size() == 0:
if cv.num_children() == 0:
base_nbytes = 0
else:
chars_size = get_element(
offset_child_column, offset_child_column.size()-1).value
base_nbytes = chars_size
# get the size from offset child column (device to host copy)
offsets_column_index = 0
offset_child_column = cv.child(offsets_column_index)
if offset_child_column.size() == 0:
base_nbytes = 0
else:
chars_size = get_element(
offset_child_column, offset_child_column.size()-1).value
base_nbytes = chars_size

if data_ptr:
if data_owner is None:
Expand Down
Loading