Fix groupby.get_group with length-1 tuple with list-like grouper #17216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
vyasr
approved these changes
Oct 31, 2024
|
/merge |
Comment on lines
+484
to
+488
| if is_list_like(self._by): | ||
| if isinstance(name, tuple) and len(name) == 1: | ||
| name = name[0] | ||
| else: | ||
| raise KeyError(name) |
There was a problem hiding this comment.
hey - was this missing a if is_list_like(self._by) and len(self._by) ==1?
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
) #17216 added similar logic to what's in pandas https://github.com/pandas-dev/pandas/blob/602ae10f3d0d599ebbdd151e8a09f0baf20b4637/pandas/core/groupby/groupby.py#L787-L794, but missed one crucial ingredient: checking that the length of the keys is `1` before raising Authors: - Marco Edward Gorelli (https://github.com/MarcoGorelli) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #17653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #17187
Adds similar logic as implemented in pandas: https://github.com/pandas-dev/pandas/blob/main/pandas/core/groupby/groupby.py#L751-L758
Checklist