Fix reading of single-row unterminated CSV files #17305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug-read_csv-single-row
…bug-read_csv-single-row
…bug-read_csv-single-row
github-actions
bot
added
libcudf
3 tasks
vuule
changed the title
vuule
commented
Nov 14, 2024
|
|
||
| std::vector<char> first_row = header; | ||
| // Empty row, return empty column names vector | ||
| if (row.empty()) { return {}; } |
There was a problem hiding this comment.
Turns out, the line terminator is cropped when it's the only character(s) on the line, so we don't need to account for that case. The only empty row is an actually empty line (zero characters).
Added tests for this assumption.
bdice
approved these changes
Nov 14, 2024
davidwendt
approved these changes
Nov 14, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the logic in the CSV reader that led to empty output instead of producing a table with a single column and one row.
Added tests to make sure the new logic does not cause regressions.
Also did some small clean up around the fix.
Checklist