Update java datetime APIs to match CUDF. #17329
Merged
+477
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
added
3 - Ready for Review
jlowe
reviewed
Nov 14, 2024
mythrocks
reviewed
Nov 14, 2024
mythrocks
reviewed
Nov 14, 2024
java/src/test/java/ai/rapids/cudf/TimestampColumnVectorTest.java
Outdated
Show resolved
Hide resolved
mythrocks
reviewed
Nov 14, 2024
jlowe
approved these changes
Nov 14, 2024
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
/merge |
gerashegalov
approved these changes
Nov 14, 2024
| @@ -1045,6 +1048,16 @@ public final ColumnVector addCalendricalMonths(ColumnView months) { | |||
| return new ColumnVector(addCalendricalMonths(getNativeView(), months.getNativeView())); | |||
| } | |||
|
|
|||
| /** | |||
| * Add the specified number of months to the timestamp. | |||
| * @param months must be a INT16 scalar indicating the number of months to add. A negative number | |||
There was a problem hiding this comment.
Suggested change
| * @param months must be a INT16 scalar indicating the number of months to add. A negative number | |
| * @param months must be an INT16 scalar indicating the number of months to add. A negative number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the java APIs related to datetime processing so that they match the CUDF APIs.
Checklist