Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support polars 1.14 #17355

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Support polars 1.14 #17355

merged 3 commits into from
Nov 19, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Nov 18, 2024

Description

1.13 was yanked for some reason, but 1.14 doesn't bring anything new and difficult.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners November 18, 2024 17:42
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Nov 18, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2024
@wence-
Copy link
Contributor Author

wence- commented Nov 18, 2024

/merge

@davidwendt
Copy link
Contributor

Looks like something is causing the cudf-polars-polars-test to hang.
https://github.com/rapidsai/cudf/actions/runs/11898001278/job/33164817268?pr=17355

@vyasr
Copy link
Contributor

vyasr commented Nov 18, 2024 •
edited
Loading

Based on the first run of that job it looks like the test that it's waiting on is indeed something that could hang :(

py-polars/tests/unit/test_plugins.py::test_is_dynamic_lib_dir PASSED     [ 95%]
context canceled
py-polars/tests/unit/test_polars_import.py::test_fork_safety 
Error: The operation was canceled.

@wence-
Copy link
Contributor Author

wence- commented Nov 18, 2024

Based on the first run of that job it looks like the test that it's waiting on is indeed something that could hang :(

py-polars/tests/unit/test_plugins.py::test_is_dynamic_lib_dir PASSED     [ 95%]
context canceled
py-polars/tests/unit/test_polars_import.py::test_fork_safety 
Error: The operation was canceled.

Add that one to deselected tests, I forgot sorry

@galipremsagar galipremsagar requested a review from a team as a code owner November 19, 2024 01:31
@galipremsagar
Copy link
Contributor

Add that one to deselected tests, I forgot sorry

Done

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 5f9a97f into rapidsai:branch-24.12 Nov 19, 2024
107 checks passed
@wence- wence- deleted the wence/fea/polars-1.14 branch November 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/packaging-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@wence- wence-

@galipremsagar galipremsagar

Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wence- @davidwendt @vyasr @galipremsagar @brandon-b-miller