-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid cudf.dtype
internally in favor of pre-defined, supported types
#17839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Feb 4, 2025
Comment on lines
+830
to
+831
int64 = np.dtype(np.int64) | ||
max_int = np.iinfo(int64).max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record I did some quick timings to see if these are worth caching (they're probably not):
In [2]: %timeit np.dtype(np.int64)
129 ns ± 0.738 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
In [6]: %timeit np.iinfo(np.dtype(np.int64))
563 ns ± 1.12 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
In [7]: %timeit np.iinfo(np.dtype(np.int64)).max
633 ns ± 5.25 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
/merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xref #12494 and #12495
cudf.dtype
is useful when cudf is passed adtype
argument from a user to perform inference on the input to make it cudf-compatable. Internally, we don't need this inference because we know the exact types to be passed & that are supported by cudf (columns), so this PR avoids callingcudf.dtype
internally.Generally:
CUDF_STRING_DTYPE
as a definitive cudf Python string type instead ofcudf/np.dtype("O"/"object", "str")
np.<type>
instead of"<type>"
(usingnp.
like an enum namespace)Checklist