Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy data access by making attribute private #17890

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

galipremsagar
Copy link
Contributor

Description

data attribute of numpy should be marked private as it actually points to the underlying memory and it will be distinct for a cupy array.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jan 31, 2025
@galipremsagar galipremsagar self-assigned this Jan 31, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner January 31, 2025 19:00
@galipremsagar galipremsagar requested review from wence- and bdice January 31, 2025 19:00
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jan 31, 2025
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jan 31, 2025
@vyasr vyasr changed the base branch from branch-25.02 to branch-25.04 January 31, 2025 19:36
@galipremsagar galipremsagar changed the base branch from branch-25.04 to branch-25.02 January 31, 2025 19:39
@galipremsagar galipremsagar changed the title Fix numpy data access by making attribute private Fix numpy data access by making attribute privat Feb 3, 2025
@galipremsagar galipremsagar changed the title Fix numpy data access by making attribute privat Fix numpy data access by making attribute private Feb 3, 2025
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 3, 2025
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d4bda07 into rapidsai:branch-25.02 Feb 3, 2025
123 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants